Skip to content

Feat/responsive work table details - #45

Merged
dmaman86 merged 2 commits into
mainfrom
feat/responsive-work-table-details
Aug 26, 2026
Merged

Feat/responsive work table details#45
dmaman86 merged 2 commits into
mainfrom
feat/responsive-work-table-details

Conversation

@dmaman86

Copy link
Copy Markdown
Owner

No description provided.

@dmaman86
dmaman86 merged commit 5d271f3 into main Aug 26, 2026
1 check passed
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 92.18750% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/domain/services/date.service.ts 50.00% 2 Missing ⚠️
...tures/work-table/hooks/workTableDayStateContext.ts 85.71% 2 Missing ⚠️
...features/work-table/hooks/useWorkTableDayState.tsx 90.90% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f631049b00

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +30 to +32
const { localShift, update, toggleDuty, saved, setSaved } = useShift({
shift,
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Persist shift drafts across responsive layout swaps

When the viewport crosses the sm breakpoint while a shift is being edited—for example, when rotating a phone—WorkTable replaces ShiftRow with ShiftCard, unmounting this useShift instance. The shared provider retains only the last saved ShiftEntry, while localShift (including unsaved time and duty edits) and saved remain component-local, so the new layout discards the draft and reopens previously saved shifts in edit mode. Store the editor draft and saved state in the shared day state, or avoid unmounting the active editor during layout changes.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants